Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove default styling from a tag in card component #9681

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

michalgrzegorczyk-dev
Copy link
Contributor

Fixes #9664

@michalgrzegorczyk-dev michalgrzegorczyk-dev requested a review from a team as a code owner November 4, 2024 23:15
@michalgrzegorczyk-dev michalgrzegorczyk-dev requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team November 4, 2024 23:15
Copy link

lumberjack-bot bot commented Nov 4, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.23%. Comparing base (4a26b1a) to head (fca015f).
Report is 589 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9681      +/-   ##
==========================================
- Coverage   75.68%   75.23%   -0.46%     
==========================================
  Files        1216     1246      +30     
  Lines       19068    19562     +494     
  Branches     2091     2118      +27     
==========================================
+ Hits        14432    14717     +285     
- Misses       4592     4799     +207     
- Partials       44       46       +2     
Flag Coverage Δ
summary 75.23% <ø> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Nov 4, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
298.67KB +10%
demo/browser/vendor.(hash).js
259.74KB +10%
demo/browser/runtime.(hash).js
43.48KB +10%
demo/browser/styles.(hash).css
19.61KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +3B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.24MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode changed the title fix: remove default styling from <a> tag in card component fix: remove default styling from a tag in card component Nov 5, 2024
@splincode splincode merged commit 1b6e32b into taiga-family:main Nov 5, 2024
25 of 26 checks passed
shiv9604 pushed a commit to shiv9604/taiga-ui that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - CardMedium as anchor has some default browser styles
3 participants