Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): Stepper fix flashing styles #9638

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

vladimirpotekhin
Copy link
Member

Fixes #9632

The first time, when the query list is empty yet, indexOf for all steps returns -1

Снимок экрана 2024-10-30 в 10 58 07

If we set -1 to the [activeItemIndex] input of the stepper, it will cause the styles to flash since all steps are active for a millisecond.

2024-10-30.11.02.43.mov

@vladimirpotekhin vladimirpotekhin requested a review from a team as a code owner October 30, 2024 08:16
@vladimirpotekhin vladimirpotekhin requested review from MarsiBarsi, waterplea, nsbarsukov and mdlufy and removed request for a team October 30, 2024 08:16
Copy link

lumberjack-bot bot commented Oct 30, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 94b6f9b):

https://taiga-previews--pr9638-fix-step-flashing-bhgyqjep.web.app

(expires Thu, 31 Oct 2024 08:20:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Oct 30, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
298.46KB +10%
demo/browser/vendor.(hash).js
255.67KB +10%
demo/browser/runtime.(hash).js
43.38KB +10%
demo/browser/styles.(hash).css
19.61KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +9B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.22MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@vladimirpotekhin vladimirpotekhin merged commit 059c1de into main Nov 5, 2024
30 checks passed
@vladimirpotekhin vladimirpotekhin deleted the fix-step-flashing branch November 5, 2024 08:22
shiv9604 pushed a commit to shiv9604/taiga-ui that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - flashing default styles for stepper
3 participants