Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): InputPhone fix format paste if value has space after plus sign #9634

Conversation

nezar-khamidekh
Copy link
Contributor

Fixes #9592

@nezar-khamidekh nezar-khamidekh requested a review from a team as a code owner October 29, 2024 13:29
@nezar-khamidekh nezar-khamidekh requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team October 29, 2024 13:29
Copy link

lumberjack-bot bot commented Oct 29, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.20%. Comparing base (4a26b1a) to head (4078440).
Report is 547 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9634      +/-   ##
==========================================
- Coverage   75.68%   75.20%   -0.49%     
==========================================
  Files        1216     1246      +30     
  Lines       19068    19545     +477     
  Branches     2091     2125      +34     
==========================================
+ Hits        14432    14699     +267     
- Misses       4592     4799     +207     
- Partials       44       47       +3     
Flag Coverage Δ
summary 75.20% <ø> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Oct 29, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
298.45KB +10%
demo/browser/vendor.(hash).js
255.67KB +10%
demo/browser/runtime.(hash).js
43.39KB +10%
demo/browser/styles.(hash).css
19.61KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +4B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.22MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Member

@nsbarsukov nsbarsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@nsbarsukov nsbarsukov merged commit 2b54390 into taiga-family:main Oct 29, 2024
26 checks passed
@nezar-khamidekh nezar-khamidekh deleted the fix/input-phone-value-with-space-after-plus-sign branch October 29, 2024 15:06
shiv9604 pushed a commit to shiv9604/taiga-ui that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - InputPhone fails to format paste if value has space after plus sign
3 participants