Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(legacy): InputTime & InputDateTime support AM / PM formats #9595

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

nsbarsukov
Copy link
Member

Fixes #1229

@nsbarsukov nsbarsukov self-assigned this Oct 23, 2024
Copy link

lumberjack-bot bot commented Oct 23, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Oct 23, 2024

Visit the preview URL for this PR (updated for commit f5e7f1c):

https://taiga-previews--pr9595-time-am-pm-3zlems42.web.app

(expires Fri, 25 Oct 2024 12:00:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Oct 23, 2024

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
297.52KB (+292B +0.1%) +10%
demo/browser/runtime.(hash).js
43.27KB (+44B +0.1%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
255.67KB +10%
demo/browser/styles.(hash).css
19.61KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +336B +0.05%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.17MB (+4.7KB +0.06%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@nsbarsukov nsbarsukov force-pushed the time-am-pm branch 3 times, most recently from af255ba to 6e6aa25 Compare October 23, 2024 15:39
@nsbarsukov nsbarsukov marked this pull request as ready for review October 24, 2024 10:17
@nsbarsukov nsbarsukov requested a review from a team as a code owner October 24, 2024 10:17
@nsbarsukov nsbarsukov requested review from MarsiBarsi, waterplea, vladimirpotekhin and mdlufy and removed request for a team October 24, 2024 10:17
@nsbarsukov nsbarsukov merged commit 0f67a78 into main Oct 24, 2024
29 of 30 checks passed
@nsbarsukov nsbarsukov deleted the time-am-pm branch October 24, 2024 13:13
shiv9604 pushed a commit to shiv9604/taiga-ui that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🚀 - Support 12h am/pm input in InputTime
3 participants