Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(addon-commerce): InputCardGroup safari autofill focus #9520

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix(addon-commerce): InputCardGroup safari autofill focus #9520

merged 1 commit into from
Oct 21, 2024

Conversation

mdlufy
Copy link
Collaborator

@mdlufy mdlufy commented Oct 16, 2024

Fixes #9410

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 16, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 23e32c4):

https://taiga-previews--pr9520-mdlufy-focus-input-f-1ae719ws.web.app

(expires Sun, 20 Oct 2024 11:49:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Oct 16, 2024 •
edited
Loading

BundleMon

Unchanged files (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 295.88KB +10%
✅ demo/browser/vendor.(hash).js
 255.66KB +10%
✅ demo/browser/runtime.(hash).js
 43.22KB +10%
✅ demo/browser/styles.(hash).css
 19.31KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change +1B 0%

Unchanged groups (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.16MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@mdlufy mdlufy changed the title [WIP] fix(addon-commerce): InputCardGroup safari autofill focus [WIP][DON'T MERGE] fix(addon-commerce): InputCardGroup safari autofill focus Oct 19, 2024
@mdlufy mdlufy changed the title [WIP][DON'T MERGE] fix(addon-commerce): InputCardGroup safari autofill focus fix(addon-commerce): InputCardGroup safari autofill focus Oct 21, 2024
@mdlufy mdlufy marked this pull request as ready for review October 21, 2024 05:47
@mdlufy mdlufy requested a review from a team as a code owner October 21, 2024 05:47
@mdlufy mdlufy requested review from MarsiBarsi, nsbarsukov and vladimirpotekhin and removed request for a team October 21, 2024 05:47
@mdlufy mdlufy merged commit 7858373 into main Oct 21, 2024
25 checks passed
@mdlufy mdlufy deleted the mdlufy/focus-input-fix branch October 21, 2024 05:47
@taiga-family-bot taiga-family-bot mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splincode splincode splincode approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner automatically assigned from taiga-family/core-team

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner automatically assigned from taiga-family/core-team

Assignees

@mdlufy mdlufy

Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - InputCardGroup wrong autofill behaviour
3 participants
@mdlufy @waterplea @splincode