Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(addon-doc): improve active zone for copy button #9510

Merged
merged 1 commit into from
Oct 17, 2024
Merged

feat(addon-doc): improve active zone for copy button #9510

merged 1 commit into from
Oct 17, 2024

Conversation

splincode
Copy link
Member

Before

image

After

image

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 15, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit e1bb7ea):

https://taiga-previews--pr9510-splincode-feat-ux-co-c2dfsiuh.web.app

(expires Fri, 18 Oct 2024 12:43:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Oct 15, 2024 •
edited
Loading

BundleMon

Unchanged files (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 295.05KB +10%
✅ demo/browser/vendor.(hash).js
 255.06KB +10%
✅ demo/browser/runtime.(hash).js
 43.17KB +10%
✅ demo/browser/styles.(hash).css
 16.27KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change +4B 0%

Unchanged groups (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.16MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@splincode splincode requested a review from a team as a code owner October 17, 2024 12:39
@splincode splincode enabled auto-merge (squash) October 17, 2024 12:45
@splincode splincode merged commit 424496b into main Oct 17, 2024
25 checks passed
@splincode splincode deleted the splincode/feat-ux-copy branch October 17, 2024 13:02
@taiga-family-bot taiga-family-bot mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdlufy mdlufy mdlufy approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov

Assignees

@splincode splincode

Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@splincode @waterplea @mdlufy