Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout): CardLarge with headless Cell list #9114

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

mdlufy
Copy link
Collaborator

@mdlufy mdlufy commented Sep 20, 2024

Close #9077

Just add

&:last-of-type {
            margin-bottom: -0.5rem;
        }

Add new example with Cell headless

And changed demo examples order:
New example 13th -> 8th,
8th -> 9th, 9th -> 13th

@github-actions github-actions bot added the v4 4.0 candidate label Sep 20, 2024
Copy link

lumberjack-bot bot commented Sep 20, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 253906e):

https://taiga-previews--pr9114-mdlufy-cardlarge-7ncwkojv.web.app

(expires Sat, 21 Sep 2024 08:06:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Sep 20, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/runtime.(hash).js
42.36KB (+47B +0.11%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/main.(hash).js
287.32KB +10%
demo/browser/vendor.(hash).js
247.15KB +10%
demo/browser/styles.(hash).css
16.18KB +10%
demo/browser/polyfills.(hash).js
11.2KB +10%

Total files change +47B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.06MB (+9.53KB +0.13%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@mdlufy mdlufy marked this pull request as ready for review September 20, 2024 09:05
@mdlufy mdlufy changed the title [WIP] fix(layout): CardLarge with headless Cell list fix(layout): CardLarge with headless Cell list Sep 20, 2024
@mdlufy mdlufy merged commit 941c856 into main Sep 23, 2024
30 of 31 checks passed
@mdlufy mdlufy deleted the mdlufy/cardlarge branch September 23, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

🐞 - tuiCell bottom and top margins are not equal
3 participants