Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): fix scroll jumping on readonly input focusing in safari #9088

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

vladimirpotekhin
Copy link
Member

@vladimirpotekhin vladimirpotekhin commented Sep 19, 2024

Close #7443

when trying to focus with a tab (or programmatically) on a readonly input with the -webkit-user-select: none property, desktop safari unexpectedly resets the scroll

https://stackblitz.com/edit/vitejs-vite-drvcag?file=index.html,style.css,main.js&terminal=dev

Copy link

lumberjack-bot bot commented Sep 19, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 7a750e6):

https://taiga-previews--pr9088-safari-fix-scroll-nrdkibzo.web.app

(expires Fri, 20 Sep 2024 08:48:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Sep 19, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
286.76KB (-339B -0.12%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
247.15KB +10%
demo/browser/runtime.(hash).js
42.31KB +10%
demo/browser/styles.(hash).css
16.19KB +10%
demo/browser/polyfills.(hash).js
11.2KB +10%

Total files change -338B -0.05%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.05MB (-393B -0.01%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@waterplea waterplea merged commit dbf2510 into main Sep 19, 2024
30 of 31 checks passed
@waterplea waterplea deleted the safari-fix-scroll branch September 19, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 4.0 candidate
3 participants