fix(cdk): unsubscribe from swipe service when directive is destroyed #9022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splincode
requested review from
waterplea,
MarsiBarsi,
vladimirpotekhin,
nsbarsukov and
mdlufy
as code owners
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
|
Visit the preview URL for this PR (updated for commit c25def4): https://taiga-previews--pr9022-splincode-swipe-refa-n0wvtltt.web.app (expires Wed, 18 Sep 2024 14:55:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a |
BundleMonUnchanged files (5)
Total files change -4B 0% Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
splincode
force-pushed
the
splincode/swipe-refactor
branch
from
4d824e2
to
2c3f814
Compare
splincode
force-pushed
the
splincode/swipe-refactor
branch
from
2c3f814
to
4b16c54
Compare
splincode
force-pushed
the
splincode/swipe-refactor
branch
from
4b16c54
to
c25def4
Compare
vladimirpotekhin
approved these changes
Sep 18, 2024
mdlufy
approved these changes
Sep 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.