Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-commerce): tuiAmount hiding negative sign when value is zero #10147

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

rashiddok
Copy link
Contributor

Fixes #10127

@rashiddok rashiddok requested a review from a team as a code owner January 13, 2025 06:34
@rashiddok rashiddok requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team January 13, 2025 06:34
Copy link

lumberjack-bot bot commented Jan 13, 2025

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

bundlemon bot commented Jan 13, 2025

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
308.24KB +10%
demo/browser/vendor.(hash).js
260.27KB +10%
demo/browser/runtime.(hash).js
44.93KB +10%
demo/browser/styles.(hash).css
20.27KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

No change in files bundle size

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.62MB (+82B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode
Copy link
Member

please add an example
image

@vladimirpotekhin vladimirpotekhin merged commit 9244f1a into taiga-family:main Jan 13, 2025
36 checks passed
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (c921b4a) to head (228bdf7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@      Coverage Diff      @@
##   main   #10147   +/-   ##
=============================
=============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - tuiAmount should not show a negative sign when the value is zero
3 participants