[Lang] MatrixField refactor 5/n: Lower access of matrix field element into CHI IR #6119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
AD1024
reviewed
Sep 21, 2022
jim19930609
reviewed
Sep 21, 2022
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5959
Brief Summary
This PR lowers access of matrix field element into CHI IR. To verify its functionality, this PR also makes the following path of #5959 running end-to-end (currently only enabled when
real_matrix=True):Key steps:
MatrixField, createIndexExpressionin C++ instead of building_MatrixFieldElementin PythonIndexExpressionto takeMatrixFieldExpressionMatrixOfGlobalPtrStmt; addlower_matrix_ptrpass, which demotesPtrOffsetStmt(MatrixOfGlobalPtrStmt)intoGlobalPtrStmtin the case of constant index - this is incomplete and only aims at supporting the above path