Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ir] spererate UnaryOpType::cast into cast_value and cast_bits #889

Closed
archibate opened this issue Apr 27, 2020 · 1 comment · Fixed by #892
Closed

[ir] spererate UnaryOpType::cast into cast_value and cast_bits #889

archibate opened this issue Apr 27, 2020 · 1 comment · Fixed by #892
Assignees
@archibate
Labels
c++ C++ engineering related enhancement Make existing things or codebases better feature request Suggest an idea on this project ir IR related issues

Comments

@archibate
Copy link
Collaborator

archibate commented Apr 27, 2020 •
edited
Loading

Concisely describe the proposed feature
I'd like to spererate UnaryOpType::cast into two type: cast_value and cast_bits, so that no cast_by_value entry required and simplify codegen logic.

Describe the solution you'd like (if any)
Simply rename them, and tweak logic in the backend codegens, jit evaluators, etc. to simpler.

Additional comments
Helps logic simplification for JITEvaluatorId in #839.
@archibate archibate added feature request Suggest an idea on this project c++ C++ engineering related enhancement Make existing things or codebases better ir IR related issues labels Apr 27, 2020
@archibate archibate changed the title [IR] spererate UnaryOpType::cast into cast_value and cast_bits [ir] spererate UnaryOpType::cast into cast_value and cast_bits Apr 27, 2020
@yuanming-hu
Copy link
Member

Good point - I think this is an improved design. Please go ahead :-)

We may also need to add a bool UnaryOpStmt::is_cast() const helper.

Thanks.

@archibate archibate self-assigned this Apr 27, 2020
@archibate archibate mentioned this issue Apr 27, 2020
Merged
@archibate archibate linked a pull request Apr 28, 2020 that will close this issue
[ir] [refactor] Separate UnaryOpType::cast into cast_value and cast_bits #892
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@archibate archibate

Labels
c++ C++ engineering related enhancement Make existing things or codebases better feature request Suggest an idea on this project ir IR related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ir] [refactor] Separate UnaryOpType::cast into cast_value and cast_bits archibate/taichi
2 participants
@yuanming-hu @archibate