[Lang] Support break in native for statement #8352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview canceled.
|
for more information, see https://pre-commit.ci
bobcao3
reviewed
Sep 20, 2023
| stmts.push_back<WhileControlStmt>(while_stmt->mask, const_true); | ||
| auto mask = stmts.push_back<AllocaStmt>(PrimitiveType::i32); | ||
| auto const_stmt = | ||
| stmts.push_back<ConstStmt>(TypedConstant((int32)0xFFFFFFFF)); |
There was a problem hiding this comment.
Why is the mask forced to all threads? (also why is there a mask...?)
|
IIRC the for loop should be converted to while statement if there is a break inside it, and the for statement is only for perfect for loops which do not break. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: fix #8351
Brief Summary
🤖 Generated by Copilot at f484174
This pull request adds support for the break statement in for loops in Taichi. It modifies the IR, the LLVM code generator, and the AST lowering transform to handle the break statement correctly. It also adds a test case to
tests/python/test_for_break.pyto verify the functionality.Walkthrough
🤖 Generated by Copilot at f484174
WhileControlStmtwith a constant true condition and a mask (link)is_for_loopto theWhileControlStmtconstructor to indicate whether it is a break statement in a for loop (link)WhileControlStmtwithis_for_loopset to true by jumping to the after loop block of the current for loop (link, link, link)current_for_after_loopto theTaskCodeGenLLVMclass to store the pointer to the after loop block of the current for loop (link)current_for_after_looppointer to null when initializing a new offloaded task to avoid using a stale pointer (link)test_for_break.pyto check the break statement in a for loop with a range iterator (link)