Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vulkan] Clear unnecessary GLSL shader files on Vulkan backend #2711

Closed
g1n0st opened this issue Aug 17, 2021 · 2 comments
Closed

[vulkan] Clear unnecessary GLSL shader files on Vulkan backend #2711

g1n0st opened this issue Aug 17, 2021 · 2 comments
Assignees
@0xzhang
Labels
good first issue A great chance for starters newcomer-only For first-time contributors only :-) refactor Refactor of API or codebases vulkan Vulkan backend welcome contribution

Comments

@g1n0st
Copy link
Contributor

g1n0st commented Aug 17, 2021

Currently, the GLSL shader files in folder taichi/backends/vulkan/shaders are outdated. Welcome contributors to remove them and make sure the dependency is clean. : )
@g1n0st g1n0st added welcome contribution good first issue A great chance for starters vulkan Vulkan backend labels Aug 17, 2021
@k-ye k-ye added the refactor Refactor of API or codebases label Aug 17, 2021
@g1n0st g1n0st added the newcomer-only For first-time contributors only :-) label Aug 18, 2021
@lucywsq lucywsq mentioned this issue Oct 11, 2021
Closed
@0xzhang
Copy link
Collaborator

0xzhang commented Oct 12, 2021

I would like to help! : )

@lucywsq
Copy link
Contributor

lucywsq commented Oct 12, 2021

Hi @0xzhang please join this slack channel, then we would respond to your problems on time. We can communicate faster as well.

@0xzhang 0xzhang mentioned this issue Oct 17, 2021
Merged
@g1n0st g1n0st closed this as completed Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xzhang 0xzhang

Labels
good first issue A great chance for starters newcomer-only For first-time contributors only :-) refactor Refactor of API or codebases vulkan Vulkan backend welcome contribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@k-ye @0xzhang @g1n0st @lucywsq