Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][example][Jacobi solver] stable fluid #1757

Closed
Eydcao opened this issue Aug 23, 2020 · 1 comment · Fixed by #1784
Closed

[Bug][example][Jacobi solver] stable fluid #1757

Eydcao opened this issue Aug 23, 2020 · 1 comment · Fixed by #1784
Labels
potential bug Something that looks like a bug but not yet confirmed

Comments

@Eydcao
Copy link
Contributor

Eydcao commented Aug 23, 2020

Describe the bug
Credits to @YuCrazing @yuanming-hu for finding the bug in stable_fluid.py example. Artifacts in stable_fluid.py example.

To Reproduce
Press the left mouse button and drag it to the left-down corner of the window, you will see a strange acceleration of the vortex and extremely white dye.

One bug about the wrong symbol of adding the correction term (by shi in Games 201 WeChat group#2, TODO credit his GitHub id here)

I also found that the bug exists in Jacobi_dual pressure passion solver if turned off, the bug goes away.

  • Side note: I would love to fix this one if not urgent, maybe 1~2 days will suffice.
@Eydcao Eydcao added the potential bug Something that looks like a bug but not yet confirmed label Aug 23, 2020
@Eydcao
Copy link
Contributor Author

Eydcao commented Aug 24, 2020

Hi I am going to close the issue since changing the symbol for correction term in bfecc and commenting the jacobi-dual is very simple.

I could help doing so after #1731 which affects this example file to avoid conflict. Or this can be done alongside @archibate working progress in that PR. Thanks for the patience and the rule of simplicity, which :> Saves a lot of bother

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential bug Something that looks like a bug but not yet confirmed
Projects
None yet
2 participants