Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] [refactor] Further refine C++ tests #1067

Closed
TH3CHARLie opened this issue May 27, 2020 · 2 comments
Closed

[Test] [refactor] Further refine C++ tests #1067

TH3CHARLie opened this issue May 27, 2020 · 2 comments
Labels
c++ C++ engineering related enhancement Make existing things or codebases better

Comments

@TH3CHARLie
Copy link
Collaborator

Concisely describe the proposed feature

As mentioned in discussions in #1058, C++ tests construct blocks and program separately and manually, which is different from the usual taichi approach, and this leads to no connection between the root block and the kernel.

For now, #1058 introduces a fake kernel to adapt to the IR system refactor. It would be reasonable to refine these C++ tests and remove these hacks. I assume that after this refinement, we'd have minimal work to do with tests when we are refactoring the IR system, instead of adding more hacks.

Describe the solution you'd like (if any)
I have no detailed solution yet but I'd like to investigate(if this is of high priority). The high-level approach would be finding out how program/kernel/ir is built through python AST and mimicking this in C++ tests.

@TH3CHARLie TH3CHARLie added feature request Suggest an idea on this project c++ C++ engineering related enhancement Make existing things or codebases better and removed feature request Suggest an idea on this project labels May 27, 2020
@k-ye
Copy link
Member

k-ye commented May 18, 2021

Covered in #2198

@k-ye k-ye closed this as completed May 18, 2021
@TH3CHARLie
Copy link
Collaborator Author

cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ C++ engineering related enhancement Make existing things or codebases better
Projects
None yet
Development

No branches or pull requests

2 participants