Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull request: fix Swift warnings, add TextColor as IBDesignable ? #10

Open
TomMajor opened this issue Aug 23, 2017 · 1 comment
Open

Pull request: fix Swift warnings, add TextColor as IBDesignable ? #10

TomMajor opened this issue Aug 23, 2017 · 1 comment

Comments

@TomMajor
Copy link

TomMajor commented Aug 23, 2017 •
edited
Loading

Hello taglia3,

Thanks for this fine CircularSlider library.
I get a couple of swift warnings with newest xcode, 8.3.3, mainly M_PI usage and unused runtime attribute 'type'.

I want to fix this. Also I want to add a IBDesignable for the text color of the value label.
Is this project still active? Do you accept a pull-request for these changes?
Thanks, Tom
@brennohayden
Copy link

M_PI -> Double.PI and M_PI_2 -> Double.pi / 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TomMajor @brennohayden