Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.0 and above, the candidate words obtained are incomplete #41

Closed
tyf2018 opened this issue Dec 4, 2021 · 8 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@tyf2018
Copy link

tyf2018 commented Dec 4, 2021

Version 3.0 and above, the candidate words obtained are incomplete, and there is no prompt for the existing phrases in the custom dictionary.
The 2.0 version works normally.

Screenshot of the above situation:

image

Can you consider fixing this problem? Because I really like the new features of the 3.0 version, and the corresponding speed is faster, unlike the 2.0 version, there is a stuttering phenomenon.

Best wishes!

@tadashi-aikawa
Copy link
Owner

It is because version 3.0 and above only use prefix match, not partial match.

https://github.com/tadashi-aikawa/obsidian-various-complements-plugin/releases

Use prefix match instead of the partial match to reduce noisy suggestions

It needed to improve performance, so it is not easy to support them. If you want to use partial match at the expense of speed, please create another issue as a Feature Request. (I'll consider it if many people need it.)

Best regards.

@tadashi-aikawa
Copy link
Owner

I just came up with a workaround implementation.

You don't need to create a new issue, maybe :)

@tadashi-aikawa tadashi-aikawa self-assigned this Dec 4, 2021
@tadashi-aikawa tadashi-aikawa added the enhancement New feature or request label Dec 4, 2021
@tyf2018
Copy link
Author

tyf2018 commented Dec 4, 2021

I just came up with a workaround implementation.

Wow, great, look forward to it.

@tadashi-aikawa
Copy link
Owner

Hi, @tyf2018.

I have uploaded beta version to tadashi-aikawa/obsidian-plugin-dev-sandbox 🚀

Could you confirm the above release note and try it by using BRAT?

@tyf2018
Copy link
Author

tyf2018 commented Dec 5, 2021

Could you confirm the above release note and try it by using BRAT?

Your development efficiency is amazing! But I am outside now, I will continue to go back to the computer at night.

@tyf2018
Copy link
Author

tyf2018 commented Dec 5, 2021

Could you confirm the above release note and try it by using BRAT?

After trial, it runs normally. Users can customize the settings according to their personal needs, which is very good! It is recommended to add it to the official version, thank you!

@tadashi-aikawa
Copy link
Owner

Users can customize the settings according to their personal needs, which is very good! It is recommended to add it to the official version,

Of course 👍 I want to release it this weekend.

@tadashi-aikawa
Copy link
Owner

Released at v3.2.0 🚀 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants