How to avoid trigger when input Non-English languages

[chenyukang]

Thank you for this awesome plugin, I love it when input English words.
But I have an issue when inputting Chinese.
Here, it will also suggest the English words:

[tadashi-aikawa]

Hi, @chenyukang!

I understood what you bother to because I think so many times while inputting Japanese with IME. So I am trying to add a new option, Disable suggestions during IME On. Would it be possible to resolve your issue?

Before (current version)

2021-11-25_23h47_18.mp4

After (The version I am trying to)

2021-11-25_23h49_01.mp4

I don't know which works correctly with your IME, but it probably works :)

[chenyukang]

Hi, @chenyukang!

I understood what you bother to because I think so many times while inputting Japanese with IME. So I am trying to add a new option, Disable suggestions during IME On. Would it be possible to resolve your issue?

Before (current version)

2021-11-25_23h47_18.mp4
After (The version I am trying to)

2021-11-25_23h49_01.mp4
I don't know which works correctly with your IME, but it probably works :)

Thanks for reply!
If you have pre-release version for testing, I would like to have a try. 😊

[chenyukang]

Btw, I guess most users in Windows use Microsoft Input.

[tadashi-aikawa]

@chenyukang
I have uploaded pre-release version 🚀

If you use BRAT, you can install it from tadashi-aikawa/obsidian-plugin-dev-sandbox. It includes some breaking changes because it corresponds to v3.0.0. You can see what changes are at #28.

Best regards.

[chenyukang]

@chenyukang I have uploaded pre-release version 🚀

If you use BRAT, you can install it from tadashi-aikawa/obsidian-plugin-dev-sandbox. It includes some breaking changes because it corresponds to v3.0.0. You can see what changes are at #28.

Best regards.

Confirmed it works perfectly, and we can also complete links now, awesome!
Thanks for your contribution. 🙌

[chenyukang]

Btw, do you have any better English dictionary files to config my dictionary.

[chenyukang]

I tried this words for complete, but it seems too big, it will hang up the plugin.
https://raw.githubusercontent.com/dwyl/english-words/master/words.txt

[chenyukang]

emm, find out this one, should be better
https://github.com/first20hours/google-10000-english/blob/master/google-10000-english.txt

[chenyukang]

The above dictionary works perfect.
But I found another improvement we may implement.

For instance, we have 'banana' in dictionary,

but if I will type this word in the beginning of a sentence, I will type "Ba", but it will not complete, I guess ignore uppercase will be better:

How do you think?

[tadashi-aikawa]

Thank you for your reply!

Confirmed it works perfectly

Glad to hear that 😄

do you have any better English dictionary files to config my dictionary.

Sorry, I have no idea because I don't use the custom dictionary feature.. 😅

but if I will type this word in the beginning of a sentence, I will type "Ba", but it will not complete, I guess ignore uppercase will be better:

That is very interesting :) Would you create another issue?

[tadashi-aikawa]

Done 97d7728