Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stdlib): add safe Slice.asAddress function #1876

Merged
merged 11 commits into from
Feb 19, 2025

Conversation

i582
Copy link
Contributor

@i582 i582 commented Feb 18, 2025

Issue

Closes #1736.
Towards #369.

Checklist

  • I have updated CHANGELOG.md
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@i582 i582 added this to the v1.6.0 milestone Feb 18, 2025
@i582 i582 requested a review from a team as a code owner February 18, 2025 04:54
@i582 i582 requested review from novusnota and Shvandre February 18, 2025 04:54
Copy link
Member

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing edits related to re-entrance of the exit code 136, I'll be swift

@anton-trunov anton-trunov self-assigned this Feb 18, 2025
@novusnota
Copy link
Member

novusnota commented Feb 19, 2025

Snapshots failed, updating those in a moment.

A brief summary: I've re-introduced the exit code 136 and made it a bit more specific: to validate the standard address, i.e. addr_std. This removes the limitations of chain IDs described in #369 and narrows the scope of currently supported inhabitants of Address type to just addr_std, with the possibility to add addr_none and, potentially, addr_extern.

Copy link
Contributor

@jeshecdom jeshecdom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs and tests LGTM

@anton-trunov anton-trunov merged commit 4c35325 into main Feb 19, 2025
25 checks passed
@anton-trunov anton-trunov deleted the pmakhnev/add-slice-as-address-function branch February 19, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an extension function asAddress(self: Slice) to the stdlib
5 participants