Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"document is not defined" using RN tachyons 3.3.2 #41

Closed
peacechen opened this issue Apr 27, 2017 · 3 comments
Closed

"document is not defined" using RN tachyons 3.3.2 #41

peacechen opened this issue Apr 27, 2017 · 3 comments

Comments

@peacechen
Copy link
Contributor

This error appeared after upgrading to 3.3.2: "Can't find variable: document"

Stack trace shows
index.js : 66
debug.js : 119
browser.js : 49

useColors() references document

@fab1an
Copy link
Member

fab1an commented Apr 27, 2017

We had this problem with debug already. Could you check this issue out: #26

@peacechen
Copy link
Contributor Author

peacechen commented Apr 27, 2017

RN tachyons' package.json has the debug dependency set to ^2.6.4. The one installed in my local node_modules is 2.6.5.
Edit: experimentally found that debug 2.6.4 works while 2.6.5 reintroduces a breaking change. 2.6.4 checks that document !== undefined, whereas 2.6.5 reverts to the prior document truthy check.

To avoid updates to the debug dependency breaking this package, remove the carat ^ in front of the version so that the exact version is installed. Created PR #42

@fab1an fab1an closed this as completed in 47b358f Apr 27, 2017
@fab1an
Copy link
Member

fab1an commented Apr 27, 2017

Thanks. I went one step further and removed the dependency alltogether, since it made problems twice already. 3.3.3 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants