Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Threshold" gating from the Excel UI #268

Open
castillohair opened this issue Jul 25, 2017 · 0 comments
Open

"Threshold" gating from the Excel UI #268

castillohair opened this issue Jul 25, 2017 · 0 comments

Comments

@castillohair
Copy link
Collaborator

Once #246 is implemented, we should have a gate called "Threshold", which would keep events below or above a specified value.

One thing to debate is whether one should be able to specify both a lower and an upper value, or just a single value and then choose whether to keep events below or above. I would favor the first option, which would make this gate functionally identical to high_low.
Another issue is that if we want to map the gating method to be specified in the Excel UI with a function name from the gate module, we would need a new gating function called threshold(). But this would be redundant with high_low. Should we use the name High-Low in the Excel UI? or should we change the name of the current high_low function in the gate module? I would favor the latter, as I think the name high_low is pretty uninformative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant