-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Suggestion] Add Slider, Toggle and Section components #13
Comments
We're already working on |
Fantastic! Can't wait to be able to use them 😄 |
@tjallingt We're hoping to finish up WRT My own thinking has always been: setting But do let me know if you think there's additional value that I'm not considering -- your feedback so far has been super valuable and we really appreciate it. |
Yea the Section component idea is a bit more out there. My basis for wanting just being able to quickly throw together forms that follow your style guide. As you say it would basically only set some margins so I agree it might not really be worth adding. On another note: the DropdownSelect elements in the style guide all have labels but currently in tableau-ui we don't have a prop to add a label. Essentially just: function DropdownSelect({ label, ...props }) {
return (
<label
style={{
display: "flex",
flexDirection: "column",
}}
>
<small style={{ color: "rgba(0,0,0,0.56)", fontSize: 10 }}>{label}</small>
<CurrentDropdownSelect {...props} />
</label>
);
} |
Closing in favor of separate issues ^ |
Slider and Toggle are mentioned in the extension-api UX Guidelines these look great and it would be amazing if we could just use them like any of the other components. Sliders might be tricky but the toggle should be relatively simple to implement...
What I mean by Section is a little bit more tricky to explain; in the extension-api UX Guidelines it also mentions how to structure a dialog, having a component to easily build out form sections with a nice header and correct padding and margins would be great. Perhaps this component could also make it easy to line up multiple columns of inputs as shown in some of the images.
The text was updated successfully, but these errors were encountered: