Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete (quarantine) media when it's redacted #31

Open
turt2live opened this issue Jan 13, 2018 · 1 comment
Open

Delete (quarantine) media when it's redacted #31

turt2live opened this issue Jan 13, 2018 · 1 comment

Comments

@turt2live
Copy link
Member

turt2live commented Jan 13, 2018

Synapse issue: matrix-org/synapse#1263

There's no spec for redactions deleting media, so one may have to be created. When the homeserver detects that a media object is dereferenced everywhere it should contact the media repo and ask it to delete the file. The homeserver should ignore the response code entirely (200, 404, etc are all valid) as it would be just a suggestion, and the repo may not implement it.

The homeserver would be responsible for tracking remotely media being redacted as well. This is to prevent the world from recommending deletion on the media repo. A shared secret auth on the API would probably be enough to verify the right homeserver is contacting the repo.

This may be possible to do with the new pluggable storage layer in synapse develop. In theory, a shim could be written to proxy the calls to us, bypassing synapse.

@turt2live turt2live added this to the v1.0.0 milestone Jan 13, 2018
@turt2live turt2live changed the title Delete/quarantine media endpoint (on redact/admin action) Delete (quarantine) media when it's redacted Jan 20, 2018
@turt2live turt2live modified the milestones: v1.0.0, v1.1.0 Jan 24, 2018
@turt2live turt2live modified the milestones: v1.1.0, v1.0.0 May 3, 2018
@turt2live turt2live mentioned this issue May 3, 2018
11 tasks
@turt2live
Copy link
Member Author

This might be possible by hooking into the Synapse replication and database to figure out which data to actually quarantine.

@turt2live turt2live modified the milestones: v1.0.0, v1.1.0 Dec 29, 2019
@turt2live turt2live added data waste wasted bandwidth, storage, etc redaction labels Feb 12, 2023
@turt2live turt2live removed this from the v1.3.0 milestone Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant