From e9c533e017fb04490820dc74204218c77856a3c0 Mon Sep 17 00:00:00 2001 From: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com> Date: Mon, 29 Jul 2019 16:36:18 -0700 Subject: [PATCH] Release build config (#6965) * Add release build configuration to release pipeline * add conditional for not equals --- eng/pipelines/client.yml | 2 +- eng/pipelines/templates/jobs/archetype-sdk-client.yml | 8 ++++++-- eng/pipelines/templates/variables/globals.yml | 6 +++++- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/eng/pipelines/client.yml b/eng/pipelines/client.yml index 06d4a08230af8..42403366934f1 100644 --- a/eng/pipelines/client.yml +++ b/eng/pipelines/client.yml @@ -14,4 +14,4 @@ jobs: - template: templates/jobs/archetype-sdk-client.yml parameters: ServiceDirectory: $(ServiceDirectory) - VersioningProperties: /p:OfficialBuildId=$(OfficialBuildId) /p:PreRelaseVersionLabel=$(PreReleaseVersionLabel) /p:DotNetFinalVersionKind=$(DotNetFinalVersionKind) + VersioningProperties: /p:OfficialBuildId=$(OfficialBuildId) /p:PreRelaseVersionLabel=$(PreReleaseVersionLabel) /p:DotNetFinalVersionKind=$(DotNetFinalVersionKind) \ No newline at end of file diff --git a/eng/pipelines/templates/jobs/archetype-sdk-client.yml b/eng/pipelines/templates/jobs/archetype-sdk-client.yml index bf25818fa394d..0ceb71d891487 100644 --- a/eng/pipelines/templates/jobs/archetype-sdk-client.yml +++ b/eng/pipelines/templates/jobs/archetype-sdk-client.yml @@ -13,7 +13,9 @@ jobs: displayName: "Use .NET Core sdk $(DotNetCoreSDKVersion)" inputs: version: "$(DotNetCoreSDKVersion)" - - script: "dotnet pack eng/service.proj -o $(Build.ArtifactStagingDirectory) -warnaserror /p:ServiceDirectory=${{parameters.ServiceDirectory}} /p:PublicSign=false ${{ parameters.VersioningProperties }}" + - script: >- + dotnet pack eng/service.proj -o $(Build.ArtifactStagingDirectory) -warnaserror /p:ServiceDirectory=${{parameters.ServiceDirectory}} + /p:PublicSign=false ${{ parameters.VersioningProperties }} /p:Configuration=$(BuildConfiguration) displayName: "Build and Package" env: DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1 @@ -112,7 +114,9 @@ jobs: inputs: packageType: sdk version: "$(DotNetCoreSDKVersion)" - - script: dotnet test eng/service.proj --filter TestCategory!=Live --framework $(TestTargetFramework) --logger "trx;LogFileName=$(TestTargetFramework).trx" /p:ServiceDirectory=${{ parameters.ServiceDirectory }} /p:IncludeSrc=false + - script: >- + dotnet test eng/service.proj --filter TestCategory!=Live --framework $(TestTargetFramework) --logger "trx;LogFileName=$(TestTargetFramework).trx" + /p:ServiceDirectory=${{ parameters.ServiceDirectory }} /p:IncludeSrc=false /p:Configuration=$(BuildConfiguration) displayName: "Build & Test ($(TestTargetFramework))" env: DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1 diff --git a/eng/pipelines/templates/variables/globals.yml b/eng/pipelines/templates/variables/globals.yml index 42dd55c32a8a1..f46bdb462afb3 100644 --- a/eng/pipelines/templates/variables/globals.yml +++ b/eng/pipelines/templates/variables/globals.yml @@ -2,4 +2,8 @@ variables: DotNetCoreSDKVersion: '3.0.100-preview5-011568' DotNetCoreRuntimeVersion: '2.1.10' OfficialBuildId: $(Build.BuildNumber) - skipComponentGovernanceDetection: true \ No newline at end of file + skipComponentGovernanceDetection: true + ${{ if ne(variables['System.TeamProject'], 'internal') }}: + BuildConfiguration: 'Debug' + ${{ if eq(variables['System.TeamProject'], 'internal') }}: + BuildConfiguration: 'Release' \ No newline at end of file