-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eraser): solves issues with eraser #725
Conversation
This library is meant to be for signatures so an erase feature doesn't really make sense. If you want to create a drawing_pad library that does this that would make more sense but I don't think an erase feature will be added to this library. |
I know, that it's not the main focus of this plugin. But actually, you have a Stackblitz link for the After struggling a lot I just found the issue I mentioned and the fix from more than 4 years ago worked pretty well. |
@szimek what do you think about this feature? We would just need to add |
@UziTech thanks for the fast review! Actually, I don't thought about the changes proposed in the issue. I refactored the code as you requested and verified it in my fork. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for simplifying it! Can you write a new test with erase and fix current tests?
I added a test that checks whether the set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
## [4.1.6](v4.1.5...v4.1.6) (2023-07-17) ### Bug Fixes * **eraser:** solves issues with eraser ([#725](#725)) ([4d881e6](4d881e6))
🎉 This PR is included in version 4.1.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hello, |
Looks like this may require Typescript 4.6 or higher |
Hi there!
I struggled a lot with implementing an
undo
anderase
feature for my canvas.After research, I found issue #421 which already provides a well-working version.
This PR includes the suggested changes which are provided by @JoeLeung32 (btw. thank you so much!)