This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Testing volunteer app #736
Merged
naman1901
merged 2 commits into
anitab-org:gsoc18-infra
from
Monal5031:testing-volunteer
Jul 15, 2018
Merged
Testing volunteer app #736
naman1901
merged 2 commits into
anitab-org:gsoc18-infra
from
Monal5031:testing-volunteer
Jul 15, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monal5031
added
Type: Testing
UI Tests, Integration Tests, Travis CI, etc.
Program: GSOC
Related to work completed during the Google Summer of Code Program.
category: testing
labels
Jun 21, 2018
Monal5031
force-pushed
the
testing-volunteer
branch
from
June 22, 2018 13:08
72abbc0
to
a69dff7
Compare
Monal5031
commented
Jun 22, 2018
if request.method == 'POST': | ||
basename = get_volunteer_resume_file_url(volunteer_id) | ||
if basename: | ||
filename = settings.MEDIA_ROOT + '/..' + basename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix for #737
Monal5031
commented
Jun 22, 2018
basename = get_volunteer_resume_file_url(volunteer_id) | ||
if basename: | ||
filename = settings.MEDIA_ROOT + '/..' + basename | ||
wrapper = FileWrapper(open(filename, 'rb')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix for #737
Monal5031
requested review from
pavankm,
naman1901,
prachi1210,
anjali-dhanuka and
abarya
June 22, 2018 13:10
Monal5031
force-pushed
the
testing-volunteer
branch
from
June 23, 2018 04:28
a69dff7
to
f9212fa
Compare
Monal5031
force-pushed
the
testing-volunteer
branch
from
June 24, 2018 06:15
f9212fa
to
02e19a6
Compare
Monal5031
force-pushed
the
testing-volunteer
branch
from
June 24, 2018 08:23
02e19a6
to
82d5ca9
Compare
Monal5031
force-pushed
the
testing-volunteer
branch
from
July 9, 2018 09:22
4ec002f
to
804cf2e
Compare
naman1901
approved these changes
Jul 11, 2018
Monal5031
force-pushed
the
testing-volunteer
branch
from
July 11, 2018 18:34
e4713d5
to
8a642cc
Compare
anjali-dhanuka
referenced
this pull request
in anjali-dhanuka/vms
Jul 15, 2018
* Testing volunteer app * Add docstrings to tests
anjali-dhanuka
referenced
this pull request
in anjali-dhanuka/vms
Jul 16, 2018
* Testing volunteer app * Add docstrings to tests
anjali-dhanuka
referenced
this pull request
in anjali-dhanuka/vms
Jul 18, 2018
* Testing volunteer app * Add docstrings to tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Program: GSOC
Related to work completed during the Google Summer of Code Program.
Type: Testing
UI Tests, Integration Tests, Travis CI, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tested shift app
Closes #735
Type of Change:
Delete irrelevant options.
Code/Quality Assurance Only
How Has This Been Tested?
To verify that tests are non-breaking change in job app use:
Checklist:
Code/Quality Assurance Only