Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Testing volunteer app #736

Merged
merged 2 commits into from
Jul 15, 2018
Merged

Conversation

Monal5031
Copy link
Contributor

Description

Tested shift app

  • Uncommented and corrected the commented tests
  • Write new tests
  • Move tests from automated-testing repo.

Closes #735

Type of Change:

Delete irrelevant options.

  • Code
  • Quality Assurance

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

To verify that tests are non-breaking change in job app use:

python manage.py test volunteer.tests.test_volunteerProfile -v 2
python manage.py test volunteer.tests.test_volunteerReport -v 2
python manage.py test volunteer.tests.test_searchVolunteer -v 2
python manage.py test volunteer.tests.test_services -v 2

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • [x]I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@Monal5031 Monal5031 added Type: Testing UI Tests, Integration Tests, Travis CI, etc. Program: GSOC Related to work completed during the Google Summer of Code Program. category: testing labels Jun 21, 2018
@anitab-org anitab-org deleted a comment Jun 21, 2018
@anitab-org anitab-org deleted a comment Jun 21, 2018
@anitab-org anitab-org deleted a comment Jun 21, 2018
@anitab-org anitab-org deleted a comment Jun 21, 2018
@Monal5031 Monal5031 force-pushed the testing-volunteer branch from 72abbc0 to a69dff7 Compare June 22, 2018 13:08
if request.method == 'POST':
basename = get_volunteer_resume_file_url(volunteer_id)
if basename:
filename = settings.MEDIA_ROOT + '/..' + basename
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for #737

basename = get_volunteer_resume_file_url(volunteer_id)
if basename:
filename = settings.MEDIA_ROOT + '/..' + basename
wrapper = FileWrapper(open(filename, 'rb'))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for #737

@Monal5031 Monal5031 changed the title WIP: Testing volunteer app Testing volunteer app Jun 22, 2018
@anitab-org anitab-org deleted a comment Jun 22, 2018
@anitab-org anitab-org deleted a comment Jun 22, 2018
@Monal5031 Monal5031 force-pushed the testing-volunteer branch from a69dff7 to f9212fa Compare June 23, 2018 04:28
@anitab-org anitab-org deleted a comment Jun 23, 2018
@anitab-org anitab-org deleted a comment Jun 23, 2018
@anitab-org anitab-org deleted a comment Jun 23, 2018
@Monal5031 Monal5031 force-pushed the testing-volunteer branch from f9212fa to 02e19a6 Compare June 24, 2018 06:15
@anitab-org anitab-org deleted a comment Jun 24, 2018
@Monal5031 Monal5031 force-pushed the testing-volunteer branch from 02e19a6 to 82d5ca9 Compare June 24, 2018 08:23
@anitab-org anitab-org deleted a comment Jun 24, 2018
@anitab-org anitab-org deleted a comment Jun 24, 2018
@Monal5031 Monal5031 force-pushed the testing-volunteer branch from 4ec002f to 804cf2e Compare July 9, 2018 09:22
@anitab-org anitab-org deleted a comment Jul 9, 2018
@anitab-org anitab-org deleted a comment Jul 9, 2018
@anitab-org anitab-org deleted a comment Jul 9, 2018
@anitab-org anitab-org deleted a comment Jul 9, 2018
@anitab-org anitab-org deleted a comment Jul 9, 2018
@anitab-org anitab-org deleted a comment Jul 9, 2018
@anitab-org anitab-org deleted a comment Jul 9, 2018
@anitab-org anitab-org deleted a comment Jul 9, 2018
@anitab-org anitab-org deleted a comment Jul 9, 2018
@anitab-org anitab-org deleted a comment Jul 9, 2018
@anitab-org anitab-org deleted a comment Jul 9, 2018
@anitab-org anitab-org deleted a comment Jul 9, 2018
@Monal5031 Monal5031 force-pushed the testing-volunteer branch from e4713d5 to 8a642cc Compare July 11, 2018 18:34
@anitab-org anitab-org deleted a comment Jul 14, 2018
@anitab-org anitab-org deleted a comment Jul 14, 2018
@anitab-org anitab-org deleted a comment Jul 14, 2018
@anitab-org anitab-org deleted a comment Jul 14, 2018
@anitab-org anitab-org deleted a comment Jul 14, 2018
@anitab-org anitab-org deleted a comment Jul 14, 2018
@naman1901 naman1901 merged commit 67729a9 into anitab-org:gsoc18-infra Jul 15, 2018
@Monal5031 Monal5031 deleted the testing-volunteer branch July 15, 2018 10:50
anjali-dhanuka referenced this pull request in anjali-dhanuka/vms Jul 15, 2018
* Testing volunteer app

* Add docstrings to tests
anjali-dhanuka referenced this pull request in anjali-dhanuka/vms Jul 16, 2018
* Testing volunteer app

* Add docstrings to tests
anjali-dhanuka referenced this pull request in anjali-dhanuka/vms Jul 18, 2018
* Testing volunteer app

* Add docstrings to tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Program: GSOC Related to work completed during the Google Summer of Code Program. Type: Testing UI Tests, Integration Tests, Travis CI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants