Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Testing Home app #733

Merged
merged 3 commits into from
Jul 21, 2018
Merged

Testing Home app #733

merged 3 commits into from
Jul 21, 2018

Conversation

Monal5031
Copy link
Contributor

@Monal5031 Monal5031 commented Jun 20, 2018

Description

Tested Home app

  • Uncommented and corrected the commented tests

Closes #734

Type of Change:

Delete irrelevant options.

  • Code
  • Quality Assurance

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

To verify that tests are non-breaking change in job app use:

python manage.py test home -v 2

and to overall project use:

python manage.py test

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • [x]I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@Monal5031 Monal5031 added Type: Testing UI Tests, Integration Tests, Travis CI, etc. Program: GSOC Related to work completed during the Google Summer of Code Program. category: testing labels Jun 20, 2018
@anitab-org anitab-org deleted a comment Jun 20, 2018
@anitab-org anitab-org deleted a comment Jun 20, 2018
@anitab-org anitab-org deleted a comment Jun 20, 2018
@anitab-org anitab-org deleted a comment Jun 20, 2018
@anitab-org anitab-org deleted a comment Jun 20, 2018
@anitab-org anitab-org deleted a comment Jun 23, 2018
@anitab-org anitab-org deleted a comment Jun 23, 2018
@anitab-org anitab-org deleted a comment Jun 24, 2018
@anitab-org anitab-org deleted a comment Jun 24, 2018
@anitab-org anitab-org deleted a comment Jun 28, 2018
@anitab-org anitab-org deleted a comment Jun 28, 2018
@anitab-org anitab-org deleted a comment Jul 9, 2018
@anitab-org anitab-org deleted a comment Jul 9, 2018
@anitab-org anitab-org deleted a comment Jul 11, 2018
@anitab-org anitab-org deleted a comment Jul 11, 2018
@Monal5031 Monal5031 requested a review from MehaKaushik July 15, 2018 14:24
@Monal5031 Monal5031 assigned MehaKaushik and unassigned abarya Jul 15, 2018
@anitab-org anitab-org deleted a comment Jul 16, 2018
@anitab-org anitab-org deleted a comment Jul 16, 2018
@anitab-org anitab-org deleted a comment Jul 16, 2018
@anitab-org anitab-org deleted a comment Jul 16, 2018
Copy link
Contributor

@MehaKaushik MehaKaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving

@anitab-org anitab-org deleted a comment Jul 18, 2018
@anitab-org anitab-org deleted a comment Jul 18, 2018
@anitab-org anitab-org deleted a comment Jul 21, 2018
@anitab-org anitab-org deleted a comment Jul 21, 2018
@mayburgos mayburgos merged commit f63da06 into anitab-org:gsoc18-infra Jul 21, 2018
@Monal5031 Monal5031 deleted the testing-home branch July 21, 2018 15:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Program: GSOC Related to work completed during the Google Summer of Code Program. Type: Testing UI Tests, Integration Tests, Travis CI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants