Tests for Job app #703

Monal5031 · 2018-05-31T13:35:28Z

Description

Tested Job app

Uncommented and corrected the commented tests
Move tests from automated testing repo
Write my own tests

Fixes #686

Type of Change:

Delete irrelevant options.

Code
Quality Assurance

Code/Quality Assurance Only

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

To verify that tests are non-breaking change in job app use:

python manage.py test job -v 2

and to overall project use:

python manage.py test

Checklist:

My PR follows the style guidelines of this project
I have performed a self-review of my own code or materials
[x]I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
Any dependent changes have been merged

Code/Quality Assurance Only

My changes generate no new warnings
My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been published in downstream modules

Monal5031 · 2018-06-05T22:02:30Z

vms/job/tests/test_jobDetails.py

-            ['event', '2017-06-15', '2017-06-17'])
-        created_job = create_job_with_details(
-            ['job', '2017-06-15', '2017-06-18', '', created_event])
+        pass


Try logging out for every test otherwise logout 1 time in class tear down.

@naman1901 @pavankm I have a doubt regarding this.
If we logout only once i.e. in tearDownClass then build time won't be affected but if we logout each time i.e. in tearDown the build time will increase since it will logout for each test.

On the other hand the if we logout once that is less correct than each time, since each test is considered independent of the other and should end their session at end of test.

Need your views on which approach to go with.

Do you have empirical data on how big a difference it makes?

Umm not really but I did notice ~5 minutes minimum increase in boot time although the bu8ld time doesn't really increase by more than ~1 minute

Ideally, we should follow the correct approach even if it takes more time. Waiting for @pavankm to present his views.

Log out every session

I also think the same.

Monal5031

Need some changes.

Monal5031 · 2018-06-05T22:07:20Z

vms/job/tests/test_jobDetails.py

+        job_details_page.click_link(job_details_page.jobs_tab)
+        self.assertEqual(job_details_page.remove_i18n(self.driver.current_url),
+                         self.live_server_url + job_details_page.job_list_page)
+        self.assertEqual(job_details_page.get_message_context(),


Make this a variable inside JobDetailsPage itself (multiple uses might be possible.)

Monal5031 · 2018-06-05T22:07:36Z

vms/job/tests/test_jobDetails.py

+        job_details_page.click_link(job_details_page.create_job_tab)
+        self.assertEqual(job_details_page.remove_i18n(self.driver.current_url),
+                         self.live_server_url + job_details_page.create_job_page)
+        self.assertEqual(job_details_page.get_message_context(), 'Please add events to associate with jobs first.')


Same as above.

Monal5031 · 2018-06-05T22:07:44Z

vms/job/tests/test_jobDetails.py

+        job_details_page.fill_job_form(job_start_after_end)
+
+        # Check error.
+        self.assertEqual(job_details_page.get_job_start_date_error(), 'Start date must be before the end date')


Monal5031 · 2018-06-05T22:08:20Z

vms/job/tests/test_model.py

+        self.assertEqual(str(job_in_db.end_date), job[2])
+        self.assertEqual(job_in_db.description, job[3])
+
+    # Checks are missing from model class


Raise issue after confirmation in tomorrow's meeting.

Workaround found:
model validation checks aren't performed until a full_clean is called explicitly from code/command-line, Forms perform full_clean on submit thats why the error messages are shown. Thus model.save() will save the instance unless there not-null constraint is broken.

What is the confusion here?

Its resolved, by mistake I wrote workaround found instead should be Solution found

Monal5031 · 2018-06-05T22:09:19Z

vms/pom/pages/jobDetailsPage.py

+    def get_message_context(self):
+        return self.events_page.get_message_context()
+
+    @staticmethod


Method can be part of BasePage will be needed by all pages.

naman1901

Looks good. I'll approve once there is clarity on the multiple login issue

prachi1210 · 2018-06-07T18:27:51Z

Review awaited from Anjali, Update and finalise PR and ping me on Slack @Monal5031

anjali-dhanuka

LGTM

anjali-dhanuka · 2018-06-09T06:29:31Z

vms/job/tests/test_jobDetails.py

-            ['event', '2017-06-15', '2017-06-17'])
-        created_job = create_job_with_details(
-            ['job', '2017-06-15', '2017-06-18', '', created_event])
+        pass


I also think the same.

Monal5031 added Type: Testing UI Tests, Integration Tests, Travis CI, etc. Program: GSOC Related to work completed during the Google Summer of Code Program. category: testing labels May 31, 2018

Monal5031 assigned pavankm and naman1901 May 31, 2018

Monal5031 requested review from pavankm, naman1901 and prachi1210 May 31, 2018 13:35

Monal5031 force-pushed the testing-job branch from 80fd542 to eed59b8 Compare May 31, 2018 13:39

anitab-org deleted a comment May 31, 2018

Monal5031 force-pushed the testing-job branch 4 times, most recently from 331a013 to 23c179e Compare June 2, 2018 13:14

anitab-org deleted a comment Jun 2, 2018

Monal5031 force-pushed the testing-job branch 2 times, most recently from 5a71384 to 8775749 Compare June 5, 2018 15:19

Monal5031 commented Jun 5, 2018

View reviewed changes

naman1901 reviewed Jun 7, 2018

View reviewed changes

prachi1210 requested a review from anjali-dhanuka June 7, 2018 18:26

naman1901 approved these changes Jun 9, 2018

View reviewed changes

Monal5031 force-pushed the testing-job branch 2 times, most recently from a718e68 to e55486d Compare June 10, 2018 01:58

anitab-org deleted a comment Jun 10, 2018

anjali-dhanuka reviewed Jun 10, 2018

View reviewed changes

pavankm approved these changes Jun 14, 2018

View reviewed changes

Monal5031 force-pushed the testing-job branch from e55486d to 992e40d Compare June 14, 2018 04:45

Tests for Job app

992e40d

anitab-org deleted a comment Jun 14, 2018

prachi1210 merged commit c505bd0 into anitab-org:gsoc18-infra Jun 14, 2018

Monal5031 deleted the testing-job branch June 14, 2018 13:34

anjali-dhanuka referenced this pull request in anjali-dhanuka/vms Jul 2, 2018

Tests for Job app (#703)

ca30def

anjali-dhanuka referenced this pull request in anjali-dhanuka/vms Jul 2, 2018

Tests for Job app (#703)

51af2b9

anjali-dhanuka referenced this pull request in anjali-dhanuka/vms Jul 3, 2018

Tests for Job app (#703)

1355f65

anjali-dhanuka referenced this pull request in anjali-dhanuka/vms Jul 3, 2018

Tests for Job app (#703)

0f7d15b

anjali-dhanuka referenced this pull request in anjali-dhanuka/vms Jul 4, 2018

Tests for Job app (#703)

2b41ec9

anjali-dhanuka referenced this pull request in anjali-dhanuka/vms Jul 6, 2018

Tests for Job app (#703)

c7b16da

anjali-dhanuka referenced this pull request in anjali-dhanuka/vms Jul 14, 2018

Tests for Job app (#703)

6eb2fc2

mayburgos unassigned pavankm Feb 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tests for Job app #703

Tests for Job app #703

Monal5031 commented May 31, 2018

Monal5031 Jun 5, 2018

Monal5031 Jun 6, 2018 •

edited

Loading

naman1901 Jun 6, 2018

Monal5031 Jun 6, 2018

naman1901 Jun 7, 2018

prachi1210 Jun 7, 2018

anjali-dhanuka Jun 9, 2018

Monal5031 left a comment

Monal5031 Jun 5, 2018

Monal5031 Jun 5, 2018

Monal5031 Jun 5, 2018

Monal5031 Jun 5, 2018

Monal5031 Jun 6, 2018

prachi1210 Jun 7, 2018

Monal5031 Jun 7, 2018

Monal5031 Jun 5, 2018

naman1901 left a comment •

edited

Loading

prachi1210 commented Jun 7, 2018

anjali-dhanuka left a comment

anjali-dhanuka Jun 9, 2018

Tests for Job app #703

Tests for Job app #703

Conversation

Monal5031 commented May 31, 2018

Description

Type of Change:

How Has This Been Tested?

Checklist:

Choose a reason for hiding this comment

Monal5031 Jun 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Monal5031 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

naman1901 left a comment • edited Loading

Choose a reason for hiding this comment

prachi1210 commented Jun 7, 2018

anjali-dhanuka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Monal5031 Jun 6, 2018 •

edited

Loading

naman1901 left a comment •

edited

Loading