From fcd05c0e43676bfd57d553ef8d52179f23f1dc52 Mon Sep 17 00:00:00 2001 From: Brit Myers Date: Thu, 9 Jan 2025 22:14:15 -0500 Subject: [PATCH] fix(sdf): Force a new change set when testing a function --- lib/sdf-server/src/service/v2/func/test_execute.rs | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/lib/sdf-server/src/service/v2/func/test_execute.rs b/lib/sdf-server/src/service/v2/func/test_execute.rs index afaed6b554..739c199445 100644 --- a/lib/sdf-server/src/service/v2/func/test_execute.rs +++ b/lib/sdf-server/src/service/v2/func/test_execute.rs @@ -3,7 +3,8 @@ use axum::{ Json, }; use dal::{ - func::authoring::FuncAuthoringClient, ChangeSetId, ComponentId, Func, FuncId, WorkspacePk, + func::authoring::FuncAuthoringClient, ChangeSet, ChangeSetId, ComponentId, Func, FuncId, + WorkspacePk, }; use serde::{Deserialize, Serialize}; use si_events::{audit_log::AuditLogKind, FuncRunId}; @@ -11,6 +12,7 @@ use si_events::{audit_log::AuditLogKind, FuncRunId}; use super::FuncAPIResult; use crate::{ extract::{AccessBuilder, HandlerContext, PosthogClient}, + service::force_change_set_response::ForceChangeSetResponse, track, }; @@ -36,10 +38,11 @@ pub async fn test_execute( Host(host_name): Host, Path((_workspace_pk, change_set_id, func_id)): Path<(WorkspacePk, ChangeSetId, FuncId)>, Json(request): Json, -) -> FuncAPIResult> { - let ctx = builder +) -> FuncAPIResult> { + let mut ctx = builder .build(access_builder.build(change_set_id.into())) .await?; + let force_change_set_id = ChangeSet::force_new(&mut ctx).await?; let func = Func::get_by_id_or_error(&ctx, func_id).await?; let func_run_id = FuncAuthoringClient::test_execute_func( @@ -75,5 +78,8 @@ pub async fn test_execute( .await?; ctx.commit().await?; - Ok(Json(TestExecuteFuncResponse { func_run_id })) + Ok(ForceChangeSetResponse::new( + force_change_set_id, + TestExecuteFuncResponse { func_run_id }, + )) }