feat: add a NATS "dead letter queue" stream for failing messages #5035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a new NATS Jetstream stream called `DEAD_LETTER_QUEUES` which will contain metadata of messages that reached their consumer's `max_deliver` limit. Currently, only the `forklift-server` consumer for the `AUDIT_LOGS` stream is configured, but more streams and consumers could be configured to use this in the future. The forklift/audit logs NATS consumer is configured to attempt `4` deliveries of each message with a linear backoff (i.e. when a message is `nack`d) of 5 seconds, then 10, then 15 for a total of 30 seconds before the message metadata is added to the "dead letter queue" stream. Note that a "failed" message is *not* deleted from its source stream, but rather skipped over by that consumer. This allows us to inspect each failed message in place in the stream and decide how to triage any remediations. Co-authored-by: Nick Gerace <[email protected]> Signed-off-by: Fletcher Nichol <[email protected]>
github-actions
bot
added
A-si-settings
nickgerace
reviewed
Nov 27, 2024
Comment on lines
+83
to
+88
| max_deliver: 4, | ||
| backoff: vec![ | ||
| Duration::from_secs(5), | ||
| Duration::from_secs(10), | ||
| Duration::from_secs(15), | ||
| ], |
nickgerace
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new NATS Jetstream stream called
DEAD_LETTER_QUEUESwhich will contain metadata of messages that reached their consumer'smax_deliverlimit. Currently, only theforklift-serverconsumer for theAUDIT_LOGSstream is configured, but more streams and consumers could be configured to use this in the future.The forklift/audit logs NATS consumer is configured to attempt
4deliveries of each message with a linear backoff (i.e. when a message isnackd) of 5 seconds, then 10, then 15 for a total of 30 seconds before the message metadata is added to the "dead letter queue" stream. Note that a "failed" message is not deleted from its source stream, but rather skipped over by that consumer. This allows us to inspect each failed message in place in the stream and decide how to triage any remediations.