fix(web): wait for all components to be loaded into the components.store before hydrating each view's geometry mapping lazily #5033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore before hydrating each view's geometry mapping lazily
vbustamante
reviewed
Nov 27, 2024
| @@ -1846,6 +1847,7 @@ export const useViewsStore = (forceChangeSetId?: ChangeSetId) => { | |||
| // then refetch (i.e. there might be updates!) | |||
| if (data.toRebaseChangeSetId === changeSetId) { | |||
| this.FETCH_VIEW(); | |||
| componentsStore.FETCH_ALL_COMPONENTS(); | |||
| this.LIST_VIEWS(); | |||
There was a problem hiding this comment.
It feels like this could cause the same race that was this PR fixes, so it makes sense to make this func async and await these calls too
There was a problem hiding this comment.
Yeah I had a similar thought too - good shout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
via Pusheen on GIPHY