fix: e2e tests weren't failing properly, amends it #4735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnrwatson
force-pushed
the
fix/amend-test-execution-for-prod-tests
branch
from
e7c19f9
to
1d367b5
Compare
johnrwatson
force-pushed
the
fix/amend-test-execution-for-prod-tests
branch
from
37c6c64
to
d8b6472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends the E2E tests to correctly fail after a third loop
Test passes:
https://github.com/systeminit/si/actions/runs/11150457035
https://github.com/systeminit/si/actions/runs/11150454023