fix: re-organize deployment pipeline for better failure handling #4486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprutton1
force-pushed
the
safer_sdf_migrations
branch
3 times, most recently
from
637c650
to
188f77d
Compare
sprutton1
force-pushed
the
safer_sdf_migrations
branch
from
90e1633
to
cfafb9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganzing the pipeline so we can catch failures to binary replacements, fail back to instance refreshes, and still continue on with migrations. We will also retry migrations on other SDFs if they fail (like if the instance is replaced out from under us)