Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the Reconcile methods add the node-name #723

Closed
guettli opened this issue Mar 31, 2023 · 1 comment
Closed

In the Reconcile methods add the node-name #723

guettli opened this issue Mar 31, 2023 · 1 comment

Comments

@guettli
Copy link
Collaborator

guettli commented Mar 31, 2023

/kind feature

Describe the solution you'd like

Example: node has errors. Customer tells us the name: testing-control-plane-6dq54.

The node gets remediated.

Now the logs of the remediation should contain testing-control-plane-6dq54.

Additionaly it would make sense to propagate the machine object name as a label for the node object.
Possible with capi 1.4 kubernetes-sigs/cluster-api#7730 this

@guettli
Copy link
Collaborator Author

guettli commented Apr 3, 2023

This is already done. See: #716 (comment)

@guettli guettli closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant