fix: allow snapshot dir to be different #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostlek
force-pushed
the
fix-dir-issue
branch
from
3dc9575 to
5c036fb
Compare
19 tasks
Yeah that seems alright to me. I confirmed walk_snapshot_dir is only ever called with the snapshot dirname. I think it was called with other directories in some previous iteration of the codebase. |
|
@all-contributors add @joostlek for code |
|
I've put up a pull request to add @joostlek! 🎉 |
noahnu
pushed a commit
that referenced
this pull request
Oct 6, 2024
## [4.7.2](v4.7.1...v4.7.2) (2024-10-06) ### Bug Fixes * allow snapshot dir to be different ([#892](#892)) ([548ec06](548ec06))
|
🎉 This PR is included in version 4.7.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
This is awesome, thank you so much |
wbyoung
added a commit
to wbyoung/watersmart
that referenced
this pull request
Nov 2, 2024
Remove unused snapshots which is possible with syrupy-project/syrupy#892 resolved & also fixes the failing test suite.
wbyoung
added a commit
to wbyoung/watersmart
that referenced
this pull request
Nov 2, 2024
Remove unused snapshots which is possible with syrupy-project/syrupy#892 resolved & also fixes the failing test suite.
wbyoung
added a commit
to wbyoung/watersmart
that referenced
this pull request
Nov 2, 2024
Remove unused snapshots which is possible with syrupy-project/syrupy#892 resolved & also fixes the failing test suite.
wbyoung
added a commit
to wbyoung/watersmart
that referenced
this pull request
Nov 2, 2024
Remove unused snapshots which is possible with syrupy-project/syrupy#892 resolved & also fixes the failing test suite.
wbyoung
added a commit
to wbyoung/watersmart
that referenced
this pull request
Nov 2, 2024
Remove unused snapshots which is possible with syrupy-project/syrupy#892 resolved & also fixes the failing test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to allow setting the dirname to something else than
__snapshots__while maintaining the functionality of a failing test suite when snapshots are unused.Related Issues
Checklist
Additional Comments
I think I changed the
test_walk_dir_skips_non_snapshot_pathtest in a wrong way, but since the function this is testing (walk_snapshot_dir) is always called in context, this isn't a real use case afaict