feat: support regex path type matching #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #532 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 1100 1105 +5
=========================================
+ Hits 1100 1105 +5 |
tophat-opensource-bot
pushed a commit
that referenced
this pull request
Aug 2, 2021
# [1.4.0](v1.3.1...v1.4.0) (2021-08-02) ### Features * support regex path type matching ([#532](#532)) ([0ff4acf](0ff4acf))
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
iamogbz
reviewed
Oct 13, 2021
| @@ -29,29 +30,35 @@ def path_type( | |||
| *, | |||
| types: Tuple["PropertyValueType", ...] = (), | |||
| strict: bool = True, | |||
| regex: bool = False, | |||
There was a problem hiding this comment.
nit. regex parameter might not have been needed since you can determine what kind of key was used i.e. plain string or regex object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
regexflag to the path_type matcher.Related Issues