feat(amber): indent multiline strings, close #193 #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next-v0.4.0 #194 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 16 16
Lines 867 867
=============================================
Hits 867 867 |
iamogbz
reviewed
Apr 17, 2020
| @@ -142,8 +153,8 @@ | |||
| # name: test_list_in_dict | |||
There was a problem hiding this comment.
This is weirdly named, more like multi_line_in_dict
iamogbz
reviewed
Apr 17, 2020
tests/test_extension_amber.py
Outdated
| @@ -28,6 +28,12 @@ def test_list_in_dict(snapshot): | |||
| assert {"value": lines} == snapshot | |||
|
|
|||
|
|
|||
| def test_deeply_nested_list_in_dict(snapshot): | |||
There was a problem hiding this comment.
nb. technically not a list?
Suggested change
| def test_deeply_nested_list_in_dict(snapshot): | |
| def test_deeply_nested_multi_line_in_dict(snapshot): |
noahnu
pushed a commit
that referenced
this pull request
Apr 18, 2020
noahnu
pushed a commit
that referenced
this pull request
Apr 19, 2020
syrupy-bot
pushed a commit
that referenced
this pull request
Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Indents multiline strings only when the parent itself is indented, this is to keep snapshots of multiline strings that are not nested in any data structure, simple.
Related Issues
Checklist