Same share folder notification displayed multiple times

[alihammadraza]

No description provided.

[Nutomic]

I'm not sure what you mean, can you explain it more clearly? Maybe it is #672?

[cedardocster]

I get the same thing: android client says "device M17 Laptop wants to share folder phone shares (id number)", I pick the folder to share, save and restart syncthing and within a minute it asks again the same thing. Also I select a second computer (the one I'm currently using) to share in the android syncthing settings, but when the subsequent repeat question comes back that second computer share is not selected

[WillMorhler]

I am having approximately this same issue. Sharing between two devices - an Android phone currently running 14.39 and a raspberry pi/raspbian running 14.40. The phone repeatedly gives the notification device [ras pi] wants to share folder [folder]. This is the only folder I am sharing to the phone. Happy to provide further info that would assist in diagnosing, particularly to determine if this is a bug or user error.

[Catfriend1]

I think this happens due to

syncthing-android/app/src/main/java/com/nutomic/syncthingandroid/service/EventProcessor.java

Line 120 in 7e3c6c0

case "FolderRejected":

where we call the addfolder dialog if the user clicks on the notification but do nothing (no report back to syncthing) if the user chose "ignore folder". I guess we need to post some REST on dismissal.

[Catfriend1]

Related: https://forum.syncthing.net/t/unexpected-continuous-devicereject-events-from-the-api-with-incrementing-ids/11800

[Catfriend1]

Commit Catfriend1/syncthing-android@36fa58a fixes the creation of duplicate notifications about the same thing. It adds the device name instead of the device id for better readability. Notification logic for device, folder accepts is moved to NotificationHandler class.

[Catfriend1]

This problem also applies to device connection consent notifications.
Also fixed by PR #1177

[Catfriend1]

@alihammadraza @cedardocster @WillMorhler
I've fixed this bug. Can you please test the debug build available at https://build.syncthing.net/repository/download/SyncthingAndroid_Build/23765:id/outputs/apk/debug/app-debug.apk and report back if it now works correctly?
Please note: This is a debug build and may cause problems. In case you want to be safe, please backup your syncthing configuration and data first.

[WillMorhler]

Thanks for the follow up and fix. Unfortunately, I'm not able to test the debug build but I do appreciate your efforts.

[xor-gate]

Its weird we have to solve this kind of event silencing in all wrappers (webgui, syncthing-android, syncthing-macosx, etcetera) and it is not in the core accessable from the REST API. @AudriusButkevicius and @calmh should I open a issue/feature request for syncthing daemon to control it?

[AudriusButkevicius]

I think (not sure) there is already one, essentially having and endpoint that lists pending invites. This way we don't have to rely on the events not rolling off.

[xor-gate]

Probably you are pointing to this one: syncthing/syncthing#4084