Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(explorer-ui): linea graph data #2918

Closed
wants to merge 1 commit into from

Conversation

bigboydiamonds
Copy link
Collaborator

@bigboydiamonds bigboydiamonds commented Jul 25, 2024

Summary by CodeRabbit

  • New Features
    • Modified the DAILY_STATISTICS_BY_CHAIN query to streamline data retrieval by removing the linea field, resulting in a more efficient response structure.
  • Bug Fixes
    • Adjusted the query response to ensure it aligns with the new data structure, enhancing overall application performance.

7d13812: explorer-ui preview link

Copy link
Contributor

coderabbitai bot commented Jul 25, 2024

Walkthrough

A modification was made to the DAILY_STATISTICS_BY_CHAIN GraphQL query by removing the linea field. This change simplifies the query, now focusing on only the base, blast, scroll, and total fields. As a result, the data returned will be lighter and potentially more efficient, but any components relying on the linea data will need to be reviewed to ensure proper functionality.

Changes

Files Change Summary
packages/explorer-ui/graphql/queries/index.ts Removed the linea field from the DAILY_STATISTICS_BY_CHAIN query, altering the data structure.

Poem

In the meadow where data flows,
A field was shorn, as everyone knows.
With linea gone, the query’s light,
Now base, blast, scroll take flight.
Hooray for changes, let’s hop and play,
A simpler path to a brighter day! 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The primary change involves the removal of the 'linea' field from the 'DAILY_STATISTICS_BY_CHAIN' GraphQL query in the explorer UI.

  • Modified packages/explorer-ui/graphql/queries/index.ts to exclude the 'linea' field from the DAILY_STATISTICS_BY_CHAIN query.
  • Ensure any UI components or functionalities dependent on the 'linea' field are updated or verified for compatibility.
  • This change simplifies the query but may impact data fetching and display related to 'linea'.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8e30911 and e358477.

Files selected for processing (1)
  • packages/explorer-ui/graphql/queries/index.ts (1 hunks)
Additional comments not posted (1)
packages/explorer-ui/graphql/queries/index.ts (1)

Line range hint 110-145:
Verify the removal of the linea field from DAILY_STATISTICS_BY_CHAIN.

The linea field has been removed from the DAILY_STATISTICS_BY_CHAIN query. Ensure that all components and functions that depend on this field are updated accordingly to prevent runtime errors.

Copy link

codecov bot commented Jul 25, 2024

Bundle Report

Changes will increase total bundle size by 402.93kB ⬆️

Bundle name Size Change
sdk-router-@synapsecns/sdk-router-cjs 521.95kB 404.94kB ⬆️
sdk-router-@synapsecns/sdk-router-esm 252.32kB 0 bytes
explorer-ui-server-cjs 895.85kB 26 bytes ⬇️
explorer-ui-edge-server-array-push 83 bytes 0 bytes
explorer-ui-client-array-push 2.34MB 26 bytes ⬇️
widget-cjs-esm 273.3kB 273.3kB ⬆️
synapse-interface-server-cjs 1.38MB 0 bytes
synapse-interface-edge-server-array-push 83 bytes 0 bytes
widget-esm-cjs (removed) 275.25kB ⬇️

Copy link

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: e358477
Status: ✅  Deploy successful!
Preview URL: https://3d4a9c44.sanguine-fe.pages.dev
Branch Preview URL: https://fix-explorer-linea-graph.sanguine-fe.pages.dev

View logs

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.71321%. Comparing base (8e30911) to head (e358477).

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #2918         +/-   ##
===================================================
+ Coverage   25.39826%   25.71321%   +0.31494%     
===================================================
  Files            785         770         -15     
  Lines          56559       55524       -1035     
  Branches          80          80                 
===================================================
- Hits           14365       14277         -88     
+ Misses         40713       39769        -944     
+ Partials        1481        1478          -3     
Flag Coverage Δ
packages 90.48563% <ø> (ø)
promexporter ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bigboydiamonds
Copy link
Collaborator Author

Fixed with helm file merge

@github-actions github-actions bot deleted the fix/explorer-linea-graph branch July 28, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant