Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: useSynapsePauseData() #2921

Merged
merged 1 commit into from
Jul 25, 2024
Merged

refactor: useSynapsePauseData() #2921

merged 1 commit into from
Jul 25, 2024

Conversation

bigboydiamonds
Copy link
Collaborator

@bigboydiamonds bigboydiamonds commented Jul 25, 2024 •
edited by github-actions bot
Loading

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 25, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Base branches to auto review (3)
  • feat/.*
  • master
  • fe-release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bigboydiamonds bigboydiamonds merged commit b48c8fc into fe/maintenance-read-method Jul 25, 2024
33 of 34 checks passed
@bigboydiamonds bigboydiamonds deleted the fe/maintenance-fetch-hook branch July 25, 2024 20:29
greptile-apps[bot]
greptile-apps bot reviewed Jul 25, 2024
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Refactored code to use React hooks for fetching and managing maintenance data, improving reusability and maintainability.

  • Updated packages/synapse-interface/components/Maintenance/functions/fetchJsonData.test.ts to use a new URL and added retry logic tests.
  • Renamed and refactored packages/synapse-interface/components/Maintenance/hooks/useSynapsePauseData.ts to a custom hook, introducing useState and useCallback.
  • Modified packages/synapse-interface/utils/hooks/useMaintenanceListener.ts to utilize the new useSynapsePauseData hook for consistency.

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@codecov Codecov
Copy link

codecov bot commented Jul 25, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 402.97kB ⬆️

Bundle name Size Change
sdk-router-@synapsecns/sdk-router-cjs 521.76kB 404.83kB ⬆️
sdk-router-@synapsecns/sdk-router-esm 252.15kB 0 bytes
synapse-interface-client-array-push 7.45MB 46 bytes ⬆️
synapse-interface-server-cjs 1.38MB 47 bytes ⬆️
synapse-interface-edge-server-array-push 83 bytes 0 bytes
widget-cjs-esm 273.3kB 273.3kB ⬆️
widget-esm-cjs (removed) 275.25kB ⬇️

aureliusbtc pushed a commit that referenced this pull request Jul 29, 2024
@bigboydiamonds
feat(synapse-interface): upgrade maintenance (#2844)
78cf6ee 
* Fetch and store Maintenance data

* Construct maintenance lists from fetched data

* Use state to construct Maintenance components

* Maintenance components working except for countdown

* useMaintenance exports bridge maintenance components

* Add Swap maintenance components in useMaintenance

* Maintenance Banners exported from useMaintenance

* Clean

* Text size in Progress Bar

* Prevent active chain pause clashes between diff instances

* Clean

* Use fetched paused bridge module list in Bridge

* Clean

* Organize

* Type Maintenance State

* Lift isFetching status to store

* Organize

* Add tests for fetchJSONData, implement retries

* Use local data source as backup when fetch retries fail

* useMaintenanceListener

* Clean, fix current chain pause selection when only single pause exists

* Clean, use jsdelivr urls

* Revert package.json, remove jest command

* Resolve file name

* Add randomized query params to cache bust git rest api

* Test URLs

* Revert changes

* No cache fetch request, update to gh pages cdn url

* yarn

* useSynapsePauseData hook (#2921)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@abtestingalpha abtestingalpha Awaiting requested review from abtestingalpha

@aureliusbtc aureliusbtc Awaiting requested review from aureliusbtc

Assignees
No one assigned
Labels
M-synapse-interface size/xs Sol Typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bigboydiamonds