fix(synapse-interface): max gas estimates #2831
Conversation
bigboydiamonds
requested review from
abtestingalpha and
aureliusbtc
as code owners
WalkthroughThe recent updates focus on simplifying the gas cost calculation and estimating tools within the project. Specifically, the Changes
Poem
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Deploying sanguine-fe with
|
| Latest commit: |
ef7cd32
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4e084863.sanguine-fe.pages.dev |
| Branch Preview URL: | https://fix-max-gas-estimates.sanguine-fe.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- packages/synapse-interface/utils/calculateGasCost.ts (3 hunks)
- packages/synapse-interface/utils/hooks/useGasEstimator.ts (1 hunks)
Additional context used
Biome
packages/synapse-interface/utils/hooks/useGasEstimator.ts
[error] 34-34: Unsafe usage of optional chaining.
If it short-circuits with 'undefined' the evaluation will throw TypeError here:
(lint/correctness/noUnsafeOptionalChaining)
Additional comments not posted (2)
packages/synapse-interface/utils/calculateGasCost.ts (2)
1-1: Remove unused import statement.The import statement for
OPTIMISMhas been removed, which is good practice to clean up unused imports.
25-25: LGTM! But verify the function usage in the codebase.The
upperLimitBufferis now a constant value of 3. This change is approved.However, ensure that this change does not impact other parts of the codebase where
upperLimitBuffermight have been dynamically adjusted based onchainId.Verification successful
Verification Complete: No Issues Found
The
upperLimitBufferis now a constant value of 3 incalculateGasCostand is not dynamically adjusted based onchainId. This change does not impact other parts of the codebase whereupperLimitBuffermight have been dynamically adjusted.
calculateGasCostusage inuseGasEstimator.tsdoes not show any dynamic adjustment ofupperLimitBufferbased onchainId.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `calculateGasCost` and check for any dynamic adjustments based on `chainId`. # Test: Search for the function usage. Expect: No dynamic adjustments based on `chainId`. rg --type typescript $'calculateGasCost'Length of output: 74
Script:
#!/bin/bash # Description: Verify all function calls to `calculateGasCost` and check for any dynamic adjustments based on `chainId`. # Test: Search for the function usage. Expect: No dynamic adjustments based on `chainId`. rg 'calculateGasCost' --type-add 'typescript:*.ts' --type-add 'typescript:*.tsx'Length of output: 502
Script:
#!/bin/bash # Extract and review the relevant code snippets from `useGasEstimator.ts` to check for any dynamic adjustments based on `chainId`. # Display lines around the usages of `calculateGasCost` in `useGasEstimator.ts` rg 'calculateGasCost' -A 5 -B 5 packages/synapse-interface/utils/hooks/useGasEstimator.tsLength of output: 1341
Script:
#!/bin/bash # Display the implementation of `calculateGasCost` in `calculateGasCost.ts` to check if `upperLimitBuffer` was previously adjusted based on `chainId`. rg 'export const calculateGasCost' -A 20 packages/synapse-interface/utils/calculateGasCost.tsLength of output: 642
| @@ -100,7 +100,7 @@ export const useGasEstimator = () => { | |||
| const gasData = (await dispatch( | |||
| fetchGasData(fromChainId) | |||
| )) as PayloadAction<GasDataState> | |||
| const { maxFeePerGas } = gasData?.payload?.gasData.formatted | |||
| const { maxFeePerGas } = gasData?.payload?.gasData.formatted || {} | |||
There was a problem hiding this comment.
LGTM! But ensure safe usage of optional chaining.
The handling of maxFeePerGas has been updated to provide a default empty object if maxFeePerGas is undefined. This change is approved.
However, ensure that optional chaining is used safely to avoid runtime errors.
- const { maxFeePerGas } = gasData?.payload?.gasData.formatted || {}
+ const { maxFeePerGas = {} } = gasData?.payload?.gasData.formatted || {}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const { maxFeePerGas } = gasData?.payload?.gasData.formatted || {} | |
| const { maxFeePerGas = {} } = gasData?.payload?.gasData.formatted || {} |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2831 +/- ##
===================================================
- Coverage 25.91575% 25.72293% -0.19282%
===================================================
Files 751 709 -42
Lines 53890 52218 -1672
Branches 80 80
===================================================
- Hits 13966 13432 -534
+ Misses 38480 37408 -1072
+ Partials 1444 1378 -66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit
maxFeePerGasto prevent potential issues.dccfd76: synapse-interface preview link