-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(synapse-interface): improve maintenance event template, remove Metis pause #2328
Conversation
WalkthroughThe updates primarily shift focus from the specific Ecotone Fork event to a more general maintenance event handling within the Synapse interface. This includes changing constants for blockchain chains, adjusting event dates, and updating related content. Additionally, the logic now accommodates a bridging pause for the Optimism and Base chains, and the interface components have been updated to reflect a broader scope of maintenance events. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Deploying sanguine with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (4)
- packages/synapse-interface/components/Maintenance/Events/example/EcotoneForkUpgrade.tsx (5 hunks)
- packages/synapse-interface/components/Maintenance/Events/template/MaintenanceEvent.tsx (1 hunks)
- packages/synapse-interface/pages/index.tsx (2 hunks)
- packages/synapse-interface/pages/state-managed-bridge/index.tsx (4 hunks)
Additional comments: 12
packages/synapse-interface/pages/index.tsx (1)
- 6-6: The import and usage of
MaintenanceBanner
are correctly implemented.packages/synapse-interface/components/Maintenance/Events/template/MaintenanceEvent.tsx (4)
- 25-46: The
MaintenanceBanner
component correctly utilizes thegetCountdownTimeStatus
anduseIntervalTimer
hooks to manage its visibility based on the maintenance schedule. The implementation follows React best practices.- 49-77: The
MaintenanceWarningMessage
component correctly determines whether to display a warning message based on the current chain IDs and the maintenance schedule. It properly uses conditional rendering to returnnull
when no warning is necessary.- 79-103: The
useMaintenanceCountdownProgress
hook correctly provides state and components related to the maintenance countdown progress bar. It uses theisChainIncluded
utility function to determine applicability based on the current chain IDs.- 112-114: The
isChainIncluded
utility function is correctly implemented to check for the inclusion of specific chain IDs within a given list. This function is essential for determining the applicability of maintenance messages and actions across different chains.packages/synapse-interface/components/Maintenance/Events/example/EcotoneForkUpgrade.tsx (4)
- 22-27: The updated constants for the Ecotone Fork event correctly reflect the new dates. This change aligns with the PR's objective to update the maintenance event system.
- 40-46: The banner content has been appropriately updated to mention the Optimism and Base chains, providing clear communication about the maintenance event.
- 63-74: The logic for determining whether to display the warning message based on the Optimism and Base chains is correctly implemented. This ensures that users are adequately informed about the maintenance event.
- 108-125: The
useEcotoneForkCountdownProgress
hook has been correctly updated to handle the bridging pause for the Optimism and Base chains during the upgrade. This change supports the PR's goal of enhancing the maintenance notification system.packages/synapse-interface/pages/state-managed-bridge/index.tsx (3)
- 89-91: The integration of
MaintenanceWarningMessage
anduseMaintenanceCountdownProgress
into theStateManagedBridge
component is correctly implemented. This update aligns with the PR's objective to standardize maintenance notifications.- 525-528: The usage of
useMaintenanceCountdownProgress
to manage the display of the maintenance countdown progress bar and to determine if the bridge is paused is correctly implemented. This enhances the user experience by providing clear and dynamic maintenance notifications.- 605-605: The conditional rendering of
MaintenanceWarningMessage
based on the maintenance event's pending status is correctly implemented. This ensures that users are only shown relevant warnings.
Improving the process for throwing up maintenance components (Banners, Bridge Pause, Bridge Warning, Event Countdown Progress Bar) quickly when we need to pause Bridge.
Created a MaintenanceEvent component that makes it easier to update for new maintenance events, with required components already installed onto Bridge pages.
To spin up new Maintenance notifications around the Bridge experience, next time we just need to update these start/end times and messages to be shown in Banner, Warning, and Event Countdown Progress Bar.
Summary by CodeRabbit
801eabea661ccd42a5e5c8e08d846f107770ee85: synapse-interface preview link