Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: prevent calls from proxy admin in fuzz tests #195

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

ChiTimesChi
Copy link
Collaborator

@ChiTimesChi ChiTimesChi commented Sep 13, 2022

Description
SynapseClientUpgradeable tests assume that an upgradeable proxy is set up for the testing.
Some of the tests are fuzzing the caller address, and the proxy admin address should be excluded, as the calls from such address are not forwarded by the proxy. This PR fixes that.

PS. The testing contracts are being reworked in the upcoming PR, so the SynapseClientUpgradeable.t.sol file is left in its current not-so-pretty form intentionally.

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #195 (e400139) into master (041e806) will increase coverage by 0.05811%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##              master        #195         +/-   ##
===================================================
+ Coverage   50.62762%   50.68573%   +0.05810%     
===================================================
  Files            188         188                 
  Lines           8604        8604                 
  Branches          82          82                 
===================================================
+ Hits            4356        4361          +5     
+ Misses          3824        3819          -5     
  Partials         424         424                 
Impacted Files Coverage Δ
agents/indexer/domain.go 52.72727% <0.00000%> (-14.54546%) ⬇️
services/scribe/backfill/contract.go 78.20513% <0.00000%> (+5.12820%) ⬆️
services/scribe/backfill/filter.go 74.69880% <0.00000%> (+6.02410%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot added 2-reviewers C-Protocol-Critical PRs that modify protocol-critical code. M-contracts Module: Contracts labels Sep 13, 2022
@ChiTimesChi ChiTimesChi merged commit ea354f8 into master Sep 13, 2022
@ChiTimesChi ChiTimesChi deleted the tests/fix-proxy-test branch September 13, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-reviewers C-Protocol-Critical PRs that modify protocol-critical code. M-contracts Module: Contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants