From 98c4d3bf562fdb55420e34b62dd13263f20f138a Mon Sep 17 00:00:00 2001 From: trajan0x <83933037+trajan0x@users.noreply.github.com> Date: Fri, 15 Sep 2023 13:53:06 -0400 Subject: [PATCH] [Scribe] remove unused config params (#1383) Co-authored-by: Trajan0x --- services/scribe/config/config.go | 4 ---- services/scribe/config/config_test.go | 3 +-- services/scribe/service/scribe_test.go | 1 - 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/services/scribe/config/config.go b/services/scribe/config/config.go index de1ce5ba7b..6d059fc501 100644 --- a/services/scribe/config/config.go +++ b/services/scribe/config/config.go @@ -14,12 +14,8 @@ import ( type Config struct { // Chains stores all chain information Chains ChainConfigs `yaml:"chains"` - // RefreshRate is the rate at which the scribe will refresh the last block height in seconds. - RefreshRate uint `yaml:"refresh_rate"` // RPCURL is the url of the omnirpc. RPCURL string `yaml:"rpc_url"` - // ConfirmationRefreshRate is the rate at which the scribe will refresh the last confirmed block height in seconds. - ConfirmationRefreshRate int64 `yaml:"confirmation_refresh_rate"` } // IsValid makes sure the config is valid. This is done by calling IsValid() on each diff --git a/services/scribe/config/config_test.go b/services/scribe/config/config_test.go index 50c3eed94f..96863c508f 100644 --- a/services/scribe/config/config_test.go +++ b/services/scribe/config/config_test.go @@ -36,8 +36,7 @@ func (c ConfigSuite) TestConfigEncodeDecode() { }, }, }, - RefreshRate: uint(gofakeit.Uint8()), - RPCURL: gofakeit.URL(), + RPCURL: gofakeit.URL(), } encodedConfig, err := testConfig.Encode() diff --git a/services/scribe/service/scribe_test.go b/services/scribe/service/scribe_test.go index 840ea9f928..8ba5d73378 100644 --- a/services/scribe/service/scribe_test.go +++ b/services/scribe/service/scribe_test.go @@ -186,7 +186,6 @@ func (s *ScribeSuite) TestLivefillParity() { maticID: "https://api.polygonscan.com/api", } scribeConfig := config.Config{ - RefreshRate: 1, Chains: []config.ChainConfig{ { ChainID: ethID,