Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with error rendering and bootstrap 3 #783

Open
jaugustin opened this issue Aug 17, 2014 · 1 comment
Open

issue with error rendering and bootstrap 3 #783

jaugustin opened this issue Aug 17, 2014 · 1 comment
Labels

Comments

@jaugustin
Copy link
Contributor

Hi,

Error on forms are rendered incorrectly because of that commit
02d8cb0#diff-460e769f42ed6a8f061c31d97916f203R60
which introduce this class form-control-feedback in a wrong way ;)

I think it should be something like this :

    <span class="glyphicon glyphicon-remove form-control-feedback"></span>
    <span class="help-block">
     .....
    </span>

And also add the class has-feedback next to has-error

I can provide a PR if needed

@sescandell
Copy link
Member

Hi @jaugustin

I can provide a PR if needed

That would be perfect!
Pull the request to branch 1.1 please

Thanks

@sescandell sescandell added the Bug label Oct 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants