Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Turbo] Add support for providing multiple mercure topics to turbo_stream_listen #2407

Merged
merged 3 commits into from
Nov 29, 2024
Merged

[Turbo] Add support for providing multiple mercure topics to turbo_stream_listen #2407

merged 3 commits into from
Nov 29, 2024

Conversation

norkunas
Copy link
Contributor

@norkunas norkunas commented Nov 26, 2024 •
edited
Loading

Q A
Bug fix? no
New feature? yes
Issues Fix #213
License MIT

@carsonbot carsonbot added Feature New Feature Turbo Status: Needs Review Needs to be reviewed labels Nov 26, 2024
@norkunas norkunas changed the title [Turbo] Add support for providing multiple mercure topics to `turbo_s… [Turbo] Add support for providing multiple mercure topics to turbo_stream_listen Nov 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

FileBefore (Size / Gzip)After (Size / Gzip)
Turbo
turbo_stream_controller.d.ts 454 B / 259 B 562 B+24% 📈 / 280 B+8% 📈
turbo_stream_controller.js 1.02 kB / 466 B 1.27 kB+24% 📈 / 535 B+15% 📈

@smnandre
Copy link
Member

Thank you @norkunas 👍

I guess there were no elegant way to avoid the value/values duo in the controller ?

@norkunas
Copy link
Contributor Author

norkunas commented Nov 26, 2024 •
edited
Loading

Thank you @norkunas 👍

I guess there were no elegant way to avoid the value/values duo in the controller ?

Didn't think of a better way without breaking, later the former one could be deprecated

@norkunas norkunas requested a review from smnandre November 26, 2024 20:02
@smnandre
Copy link
Member

phpstan can be ignored.. are the failue 8.1 related or are they our usual flakky turbo failures ? 😅

@norkunas norkunas force-pushed the turbo-multi-topics branch 2 times, most recently from 57c6fcb to 1bd9bfd Compare November 27, 2024 04:31
@norkunas
Copy link
Contributor Author

norkunas commented Nov 27, 2024 •
edited
Loading

are the failue 8.1 related or are they our usual flakky turbo failures ? 😅

some were related due to changed escape, fixed that with feature detection

smnandre
smnandre approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @norkunas! This PR will definitely make several people happy. 😊

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Nov 27, 2024
@norkunas
Copy link
Contributor Author

This PR will definitely make several people happy. 😊

Including myself so I can use it in my project :D

@Kocal
Copy link
Member

Kocal commented Nov 29, 2024

Thanks @norkunas, I've just pushed a minor modification and rebased, I will merge your PR when checks become green.

@Kocal Kocal force-pushed the turbo-multi-topics branch from 5552863 to 0eaa226 Compare November 29, 2024 15:22
@Kocal Kocal force-pushed the turbo-multi-topics branch from 0eaa226 to 2469012 Compare November 29, 2024 15:25
@Kocal
Copy link
Member

Kocal commented Nov 29, 2024

Thank you @norkunas.

@Kocal Kocal merged commit 8b6090f into symfony:2.x Nov 29, 2024
63 of 64 checks passed
@norkunas norkunas deleted the turbo-multi-topics branch November 29, 2024 15:34
@norkunas
Copy link
Contributor Author

I've hesitated to do that because php 8.1 was declared as min version and phpstorm shown incompatibility

@seb-jean
Copy link
Contributor

Thanks @norkunas

@smnandre smnandre mentioned this pull request Dec 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smnandre smnandre smnandre approved these changes

Assignees
No one assigned
Labels
Feature New Feature Status: Reviewed Has been reviewed by a maintainer Turbo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Turbo][Mercure] Allow turbo_stream_listen() to subscribe multiple topics in single connection
5 participants
@norkunas @smnandre @Kocal @seb-jean @carsonbot