make:entity repository add/remove method signature

[JB-oclock]

Hi,

i'm happy to have this two new method: it's easier to use Repository than EntityManagerInterface in Controller.

But i'm not sure that the flush parameter with default value to true is a good choice.

maker-bundle/src/Resources/skeleton/doctrine/Repository.tpl.php

Line 32 in a9b817d

public function add(<?= $entity_class_name ?> $entity, bool $flush = true): void

I see datamapper as a "transaction" use of the database, so using flush by default and not using "transaction" was not what i expect.

I just want to know your vision of the default value to true
This issue is more a discussion.

[hhamon]

But i'm not sure that the flush parameter with default value to true is a good choice.

I also agree that flushing the transaction should not be triggered implicitely. By default, the developer should ->flush() explicitely or pass true explicitely to this method.