BUG: default_sort throws an Array to string conversion error when defined as an array

[pjayme]

When a DataObject defines the default_sort property using the following convention:

private static array $default_sort = [
    'SortOrder' => 'ASC',
];

Then this throws an Array to string conversion error as updates from Feb 22’ now expects this property to be of type string rather than of type array.

The simple solution is to use the string convention instead:

private static string $default_sort = 'SortOrder ASC';

I’m raising this as I’m not sure if this should be treated as a regression since the module was capable of handling the array convention or if the expectation is that users should simply stick to using the new string convention instead? Or should the module be backwards compatible in that it can handle both conventions?

Acceptance criteria

• Default sort define as array should still work when using Gridfiled extensions.
• The bug 🐛 (cms interface) applies default sort order to CMS ordering #325 was trying to fix is not reintroduce

Original PRs

• FIX convert default_sort array when string in GridFieldOrderableRows #352
• FIX Respect default sort array in GridFieldOrderableRows #349

PRs

• FIX Handle arrays in default_sort #361

[sunnysideup]

This is going to break a lot of things, so I would love to see this fixed ASAP.

It is tricky, because you have to make sure that the "local" sort is the same as the default_sort. Probably the easiest way is to check the default_sort. If it is an array then add "local" sort (the ones compiled in the code) as a array as well and vice versa.
https://github.com/symbiote/silverstripe-gridfieldextensions/blob/3/src/GridFieldOrderableRows.php#L379-L406

[maxime-rainville]

I think this came from #325

[maxime-rainville]

Looks like it's been causing some degree of problem:

• [Warning] Array to string conversion #344
• Change $default_sort from array to string gorriecoe/silverstripe-menu#17
• Error with GridFieldOrderableRows gorriecoe/silverstripe-menu#18

[GuySartorelli]

Fixed in 3.5.1 and 3.6.1