Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridFieldOrderableRows issue when data class is Versioned and relation is has_many. #242

Closed
priyashantha opened this issue Jan 30, 2018 · 2 comments

Comments

@priyashantha
Copy link
Contributor

When the data class is Versioned and you re-order the records and publish it doesn't update the _Live table but only the stage table.

This happens because the condition in this line https://github.com/symbiote/silverstripe-gridfieldextensions/blob/master/src/GridFieldOrderableRows.php#L509 won't be true when the $table_name config is defined in the class. $class is FQN but $this->getSortTable($list) is just the table name.

@priyashantha priyashantha changed the title GridFieldOrderableRows issue when data class is Versioned. GridFieldOrderableRows issue when data class is Versioned and relation is has_many. Jan 30, 2018
@priyashantha
Copy link
Contributor Author

Fix added in PR #243

@dhensby
Copy link
Contributor

dhensby commented Jan 30, 2018

fixed with #243

@dhensby dhensby closed this as completed Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants